Smugmug: Did user JS just change?

[GeekyGirl]

Originally Posted by GeekyGirl

On our page lucasfamily.smugmug.com, I was using a mix of the random image generator (like at the top of the forum pages) and the thumb enlarge (from bigguyweb's site). The thumb enlarge is now broken. As you mouse over they will enlarge and then shrink back to a smaller size than they started. Also the gallery thumbs at the bottom of our page are now enlarging on mouse over. (Those are supposed to stay the default static size.)

When browsing an album, the thumb enlarging works like it should, so I guess it is only broken on the index page.

I don't speak javascript, so I can't figure out how to fix it. I hope someone can help me out. I appologize in advance if using the javascript and idea from bigguyweb's page is "uncool." I tried to credit him both in the CSS and javascript. I'm learning both, and its actually been really helpful to me to look at other people's code.

Thanks!

Will the new changes fix my problem? Sorry to nag. I just assumed that my problems were linked to the JS change, but if I should post in a different thread, please let me know.

Thanks again.

[Andy]

Originally Posted by GeekyGirl

Will the new changes fix my problem? Sorry to nag. I just assumed that my problems were linked to the JS change, but if I should post in a different thread, please let me know.

Thanks again.

No, your random image code needs to be updated to use AlbumKeys as well.
Example code:

http://wiki.smugmug.com/display/Smug...om+Photos+Code

[GeekyGirl]

Originally Posted by Andy

No, your random image code needs to be updated to use AlbumKeys as well.
Example code:

http://wiki.smugmug.com/display/Smug...om+Photos+Code

Hmm... Displaying the image isn't a problem. Its the movement of the image on mouseover. They are supposed to enlarge and shrink back. Right now they enlarge and then shrink to an even smaller size. They will then enlarge and shrink, but on a smaller scale. (Also the thumbnails in the "Galley Categories" section are now moving on mouseover, which they shouldn't be.)

This is how it should work: http://lucasfamily.smugmug.com/galle...0799#244876154

This is how it acts on the index page: http://lucasfamily.smugmug.com

I don't understand why it is working on the gallery pages but not on the index page.

[Andy]

Originally Posted by GeekyGirl

Hmm... Displaying the image isn't a problem. Its the movement of the image on mouseover. They are supposed to enlarge and shrink back. Right now they enlarge and then shrink to an even smaller size. They will then enlarge and shrink, but on a smaller scale. (Also the thumbnails in the "Galley Categories" section are now moving on mouseover, which they shouldn't be.)

This is how it should work: http://lucasfamily.smugmug.com/galle...0799#244876154

This is how it acts on the index page: http://lucasfamily.smugmug.com

I don't understand why it is working on the gallery pages but not on the index page.

Hmmm.. I really don't know the answer to that - but it's not JS related, either. Post a new thread in the customizing forum please.

[jfriend]

Originally Posted by GeekyGirl

Hmm... Displaying the image isn't a problem. Its the movement of the image on mouseover. They are supposed to enlarge and shrink back. Right now they enlarge and then shrink to an even smaller size. They will then enlarge and shrink, but on a smaller scale. (Also the thumbnails in the "Galley Categories" section are now moving on mouseover, which they shouldn't be.)

This is how it should work: http://lucasfamily.smugmug.com/galle...0799#244876154

This is how it acts on the index page: http://lucasfamily.smugmug.com

I don't understand why it is working on the gallery pages but not on the index page.

I don't know exactly what's going on, but there are four different sizes for the popular photo thumbs and I suspect you only want two. In your custom CSS, you have three sizes 70x70, 72x72 and 80x80 and none of them match what Smugmug puts in the HTML, 100x100. I agree with Andy, this looks like it has to do with your CSS, not Javascript.

[bigwebguy]

The footer javascript section is now live. Your existing javascript has been put back at the top of the page...where it was before the last update.

Please let us know if you have any problems.

[Allen]

Noticed all my js is in the header now. Should I move it all to the footer?
BZT, old SS, hasPath and other misc. junk. Got nuthin' that I know of that
needs to run early I think.

[bigwebguy]

Originally Posted by Allen

Noticed all my js is in the header now. Should I move it all to the footer?
BZT, old SS, hasPath and other misc. junk. Got nuthin' that I know of that
needs to run early I think.

Hey allen, yeah pretty much everything can be moved to your footer with the exception of:

SM.SmugMug.config.alterScreenHeight = -150;
//filmStrip values you can override:
rightMoves = -5;
leftMoves = 5;

some other stuff i'm not sure about since I dont know where you're using them:
function norobotmail
function showRecent


rule of thumb is, if you call it on the page before your footer (think how the page loads, top down) then you'll want it in the header. If it is something that you will wire up or use after the page loads then you can put it in the footer.

[scoodog]

Originally Posted by Andy

I'm looking at your site right now, what is in need of fixing please

After it stopped working, I disabled a part of the page allowing folks to switch display mode without having to use the dropdown styles box, which my family members had told me they didn't understand (e.g. they didn't know what was meant by "smugmug" view). Andy, what I've done is put back in my custom code AND I tried moving the JavaScript to the new FOOTER JS section, but it still isn't working.

My customization relies upon the function "switchViewType", btw.

Thanks in advance for your help.

Tom

[Andy]

Originally Posted by scoodog

After it stopped working, I disabled a part of the page allowing folks to switch display mode without having to use the dropdown styles box, which my family members had told me they didn't understand (e.g. they didn't know what was meant by "smugmug" view). Andy, what I've done is put back in my custom code AND I tried moving the JavaScript to the new FOOTER JS section, but it still isn't working.

My customization relies upon the function "switchViewType", btw.

Thanks in advance for your help.

Tom

Put it all back in the header Javascript box and it'll be just like it was 10 days ago

[bigwebguy]

Originally Posted by Andy

Put it all back in the header Javascript box and it'll be just like it was 10 days ago

Rule of thumb #2:

If it broke when we moved your scripts to the footer, don't put it back in the footer.

[scoodog]

Originally Posted by Andy

Put it all back in the header Javascript box and it'll be just like it was 10 days ago

I did this, but it still isn't working. My customization relies upon the function "switchViewType" -- I thought I read that you guys disabled that JavaScript function.

What do you think the issue is?

Thanks in advance.

[affdigphotos]

I would like to move my js to the footer wherever possible... can someone take a look at mine and see what needs to stay in the header and what doesnt?

[TexasFamily]

Where do you suggest I put album skripts that I have included in a specific album description?
It is a skript that only runs for that specific album.

Maybe a future album footer/skript section?

I only put it in the description because I didn't want it running for every album.
I think it will run fine at the end of page loading...but there is no place to put skripts just for a specific album(s).


Thanks,
Edward

[Erick L]

Here things work like they used to but I don't understand something. I had some JS for a bilingual site in the "Head Tag" (not Header). I had to move it in the Footer box but both languanges would show for an instant. Now with the two JS box, I put that code in the JS-Header but still had both languages showing. I moved it back to the Head Tag like it used to be and it works.

[PBolchover]

Thanks for the revert. That's one of the reasons why I love Smugmug - you're not afraid to listen to customer feedback.