PDA

View Full Version : Critique


Addman8
Aug-21-2006, 04:10 PM
After coming to Smugmug with very little knowledge of HTML, I am getting close to feeling temporarily satisfied with my site.

Any thoughts, feedback, or tips are appreciated!

www.mattaddington.smugmug.com

Andy
Aug-21-2006, 05:13 PM
It's looking good! I like the color scheme, and the feel.

I'd like to see you center your navbar...

Addman8
Aug-21-2006, 07:20 PM
It's looking good! I like the color scheme, and the feel.

I'd like to see you center your navbar...

Can you take a look at my code and see what the problem is? I have tried to figure it out to no avail.

thanks

AnInfiniteJourney
Aug-21-2006, 11:16 PM
Howdy Matt,
:thumb Nicely laid out - I really like your header/logo and the tiny thumbnails in the footer.

A slight problem - I'm using FF on a Mac and the words collages and family is cut in half by the map.

Mike Lane
Aug-22-2006, 06:37 AM
Can you take a look at my code and see what the problem is? I have tried to figure it out to no avail.

thanks

What is this code for?


#navcontainer ul
{
margin: 0;
padding: 0;
list-style-type: none;
text-align: center;
}

#navcontainer ul li { display: inline; }

#navcontainer ul li a

I've done a quick search of your html and I haven't found any reference to navcontainer. If you aren't using an id="navcontainer" anywhere, then you should remove all of that. No matter what you must remove the last line in red. Or you could add some styles to it surrounded by curly brackets. Either way it's messing you up as it is.

Actually I just tested removing it entirely and that centers your navbar in firefox.

Addman8
Aug-22-2006, 08:13 AM
Thanks, Mike. I am not sure what that was. A slick copy/paste from somewhere that I didn't pay close enough attention to.

One question for you...how do I make my dropdowns a little easier to "catch"? When you drop down and move the mouse over, it always seems to slip off the edge (if that makes sense)...thoughts?

What is this code for?


#navcontainer ul
{
margin: 0;
padding: 0;
list-style-type: none;
text-align: center;
}

#navcontainer ul li { display: inline; }

#navcontainer ul li a
I've done a quick search of your html and I haven't found any reference to navcontainer. If you aren't using an id="navcontainer" anywhere, then you should remove all of that. No matter what you must remove the last line in red. Or you could add some styles to it surrounded by curly brackets. Either way it's messing you up as it is.

Actually I just tested removing it entirely and that centers your navbar in firefox.

Mike Lane
Aug-22-2006, 09:01 AM
Thanks, Mike. I am not sure what that was. A slick copy/paste from somewhere that I didn't pay close enough attention to.

One question for you...how do I make my dropdowns a little easier to "catch"? When you drop down and move the mouse over, it always seems to slip off the edge (if that makes sense)...thoughts?

You'll have to add various amounts of padding to the ul elements and compensate for that padding with negative margin values. Make sure your z-index values are all set up correctly too (which they probably are).