PDA

View Full Version : Dear sorcerers


jfriend
Jul-13-2009, 02:15 PM
Dear Smugmug Sorcerers,

Because you've gone to great lengths to put IDs and classes all through the Smugmug pages, it is wonderfully customizable with both CSS and Javascript.

But, there are a few places where you have used DIVs that have styles attached to them, but there are no IDs and no classes and thus it is next to impossible to modify styling with CSS. Since I don't think you intend to lock out these styling changes, I am assuming this is just an oversight and I'm hoping you can correct the few cases I see and keep this in mind for the future to not introduce more of these.

The latest one comes in the newest Journal style in the album top navigation. Here's a screen shot of the structure from Firebug:

http://content.screencast.com/users/jfriend/folders/Jing/media/4aac9609-53e7-4afe-a131-60985f48b509/2009-07-13_1405.png

Because there are no IDs or classes, it's pretty much impossible to change the formatting of this album navigation with just CSS. Put a few IDs or classes in here (which costs you nothing) and it's easy to change the formatting with CSS. Here's a user (http://www.dgrin.com/newreply.php?do=newreply&p=1157877) who can't fix his problem because of this.

While we're on this subject, there's also a spot in the Smugmug view that has the same problem and we find ourselves wanting to modify this area of the view when people are modifying the border around their images or trying to change the position of the caption. Please fix this one also to not have naked DIVs that have embedded styling. Here's a Firebug screen shot of that case:

http://content.screencast.com/users/jfriend/folders/Jing/media/5a6e6323-004d-4559-bf26-2618da655ff9/2009-07-13_1413.png

bstrong
Jul-13-2009, 02:41 PM
Hi jfriend,

This was definitely an oversight in the new journal style. It will be fixed this week.

Thanks for pointing it out!

-Brian

jfriend
Jul-13-2009, 02:43 PM
Hi jfriend,

This was definitely an oversight in the new journal style. It will be fixed this week.

Thanks for pointing it out!

-Brian Thanks.

jfriend
Jul-14-2009, 05:19 PM
Hi jfriend,

This was definitely an oversight in the new journal style. It will be fixed this week.

Thanks for pointing it out!

-Brian Thanks for the quick fix. I was able to solve this user's problem (http://www.dgrin.com/showthread.php?p=1159542#post1159542) with plain CSS now.

But, it occurs to me that the new journal view ought to really do what he wants automatically. In his case, he does not have printable turned on. That means there are no cart buttons. When it's that way, the gallery page indicators are far left and there is nothing to the right. It looks odd. It would make more sense to just center the gallery page indicators which is what the user asked for. I did it for him with this CSS:

.gallery_3053020 .journalNav_right {display:none;}
.gallery_3053020 .journalNav_left {float:none; margin-top:10px;}
.gallery_3053020 .journal_new_entry {padding-top:10px;}

which is hiding the cart div that has a fixed size, unfloating the page numbers div and adjusting some padding.

jfriend
Aug-26-2009, 09:18 AM
The relatively new slideshow view has the same issue. There are a bunch of divs that have no class or ID so it's hard to target them uniquely with either CSS or JS. In the interest of your customizers, it seems that it really ought to be a principle that unidentified divs are not used.

Here's the ones I see in the slideshow view. These came into play when a user had the breadcrumb hidden and wanted to center the cart buttons over the image (a reasonable request), but we have to style the unnamed divs in order to do that. Please put an ID or classname on these divs.

http://content.screencast.com/users/jfriend/folders/Jing/media/0509a560-06eb-4095-9db6-38ba7ee48d1c/2009-08-26_0916.png